Merge branch 'feature/category-indexer' of github.com:Nosto/nosto-mag…

…ento2 into feature/category-indexer
Nosto · Nov 1, 2024 · ccaf9ac · ccaf9ac
2 parents d06c586 + 7d9b919
commit ccaf9ac
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 4 deletions.
diff --git a/Model/Category/Repository.php b/Model/Category/Repository.php
@@ -37,7 +37,6 @@
 namespace Nosto\Tagging\Model\Category;
 
 use Magento\Catalog\Api\Data\CategoryInterface;
-use Magento\Catalog\Model\Category;
 use Magento\Catalog\Model\CategoryRepository;
 use Magento\Catalog\Model\ResourceModel\Category\Collection as CategoryCollection;
 use Magento\Framework\Api\SearchCriteriaBuilder;
@@ -99,7 +98,7 @@ public function getCategoryCollectionQuery(Store $store, array $categoryIds = []
             ->addNameToResult()
             ->setStoreId($store->getId())
             ->addUrlRewriteToResult()
-            ->addAttributeToFilter('level', ['gt' => 1]) // @TODO: Check if zero level categories are needed
+            ->addAttributeToFilter('level', ['gt' => 1])
             ->addAttributeToSelect(array_merge(['name', 'is_active', 'include_in_menu']))
             ->addOrderField('entity_id');
 

diff --git a/Model/Indexer/Dimensions/ModeSwitcher/ModeSwitcherConfiguration.php b/Model/Indexer/Dimensions/ModeSwitcher/ModeSwitcherConfiguration.php
@@ -40,7 +40,6 @@
 use Magento\Framework\App\Cache\TypeListInterface;
 use Magento\Framework\App\Config\ConfigResource\ConfigInterface;
 
-//@TODO: needs to be abstracted to include categories as well
 class ModeSwitcherConfiguration
 {
     public const XML_PATH_PRODUCT_INDEX_DIMENSIONS_MODE = 'indexer/nosto_index_product/dimensions_mode';

diff --git a/Model/Service/Update/CategoryUpdateService.php b/Model/Service/Update/CategoryUpdateService.php
@@ -38,7 +38,6 @@
 
 use Exception;
 use Magento\Catalog\Api\Data\CategoryInterface;
-use Magento\Catalog\Model\Category;
 use Magento\Store\Model\Store;
 use Nosto\NostoException;
 use Nosto\Tagging\Exception\ParentCategoryDisabledException;