Can Message Rate Limiting #132
Merged
+229
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sabramz
requested changes
Nov 7, 2024
Core/Src/compute.c
Outdated
| 0x156; // 0x0A is the dcl id, 0x22 is the device id set by us | ||
| mc_msg.len = 8; | ||
| memcpy(mc_msg.data, &discharge_data, sizeof(discharge_data)); | ||
| bms_can_msgs[DISCHARGE].len = 8; |
There was a problem hiding this comment.
The length of the message should be defined where the CAN message is defined now where it should be sent.
| charge_msg.id = | ||
| CHARGE_CANID; // 0x0A is the dcl id, 0x157 is the device id set by us | ||
|
|
||
| can_msg_t acc_status_msg; |
There was a problem hiding this comment.
You should put message lengths in the config since they do not change and are properties of the message.
|
This is gonna hella conflict with my CAN busy fixups, so you merge first and ill refactor it. |
caiodasilva2005
force-pushed
the
Caio-CanRateLimiting
branch
from
b62c898
to
f3e444b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
added an interface to rate limit can messages
Closes #127