Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2806 created getUpcomingWorkPackages util #2843

Merged
merged 5 commits into from
Oct 22, 2024

Conversation

Jalen1
Copy link
Contributor

@Jalen1 Jalen1 commented Sep 19, 2024

Changes

Added a function in work-package utils that, when given an array of work packages, returns upcoming work packages (start date within 2 weeks).

Notes

  • Used a filter that kept work packages whose startDate value was between the current date and 2 weeks after the current date, inclusive.

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • No yarn.lock changes (unless dependencies have changed)
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes #2806

@Jalen1 Jalen1 self-assigned this Sep 19, 2024
@Jalen1 Jalen1 requested a review from vsp05 September 19, 2024 05:25
vsp05
vsp05 previously approved these changes Sep 22, 2024
Copy link
Contributor

@vsp05 vsp05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! @walker-sean should we write tests for this or is it fine?

@Jalen1 Jalen1 requested a review from vsp05 October 14, 2024 00:49
@walker-sean walker-sean merged commit 78e01a1 into develop Oct 22, 2024
4 checks passed
@walker-sean walker-sean deleted the #2806-create-getUpcomingWorkPackages-util branch October 22, 2024 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Home Page] - Create getUpcomingWorkPackages Util
3 participants