Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2831 Get organization logo endpoint and tests #2838

Merged

Conversation

chpy04
Copy link
Contributor

@chpy04 chpy04 commented Sep 17, 2024

Changes

Added endpoint to retrieve the ID of the logo image for an organization
Added tests for endpoint

Notes

Due to the uploadFile function not working locally, postman screenshots were preformed with that function replaced with {id: "Test Logo Id"}

Test Cases

  • Fails if the organization does not exist
  • Fails if the organization does not have a logo image yet
  • Returns id of image if organization has a logo image

Screenshots

Calling logo before uploading an image errors:
NoLogoImage

Update logo with:
UpdateLogo

Get logo image id with endpoint:
ReturnsLogoId

Closes #2831

@chpy04 chpy04 self-assigned this Sep 17, 2024
Copy link
Contributor

@caiodasilva2005 caiodasilva2005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@caiodasilva2005 caiodasilva2005 merged commit 1fa1529 into feature/homepage-redesign Sep 18, 2024
4 checks passed
@caiodasilva2005 caiodasilva2005 deleted the #2831-Create-getLogo-Endpoint branch September 18, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants