#2770-getUserTasks #2833
Open
#2770-getUserTasks #2833
+100
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There might be a more efficient way to query the assigned tasks. Right now you have it going through all the tasks and then finding the assignees from there. However it might be more efficient to go through the user (there is an assignedTasks field on the User object) |
bderbs30
reviewed
Sep 13, 2024
| const requestedUser = await prisma.user.findUnique({ where: { userId } }); | ||
| if (!requestedUser) throw new NotFoundException('User', userId); | ||
|
|
||
| const tasks = prisma.task.findMany({ |
There was a problem hiding this comment.
We can find the user then get assigned tasks from there. Though this might be trivial in reality and if this works then we can keep it as is. What are your thoughts?
2 tasks
…astern-Electric-Racing/FinishLine into #2770-CaioDaSilva-getUserTasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Added an endpoint to get all of a user's tasks.
Screenshots
Checklist
It can be helpful to check the
ChecksandFiles changedtabs.Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.
yarn.lockchanges (unless dependencies have changed)Closes #2770