Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2710: Created acceptance page for PNM #2827

Conversation

Zwendle
Copy link
Contributor

@Zwendle Zwendle commented Sep 9, 2024

Changes

Created frontend part of the acceptance page for PNM's.

Notes

  • FinishLine image changes size based on screen size
  • Top bar with user's name is still missing
  • Currently there is no route to this page and no way to check if a user can have permission to access this page.

Screenshots

Screenshot 2024-09-11 at 12 33 23 Screenshot 2024-09-11 at 12 33 44

To Do

  • Fix button spacing
  • Implement Electric Racing image in the center of the page

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • No yarn.lock changes (unless dependencies have changed)
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes #2710

@Zwendle Zwendle linked an issue Sep 9, 2024 that may be closed by this pull request
@Zwendle Zwendle self-assigned this Sep 9, 2024
Copy link
Contributor

@Aaryan1203 Aaryan1203 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I think you wrote it in the notes but you basically need to add the picture, fix the button spacing, and also make the text a little bigger so it matches the mocks a little more

Copy link
Contributor

@Aaryan1203 Aaryan1203 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one smal comment

Copy link
Contributor

@Aaryan1203 Aaryan1203 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linting checks are failing and just remember to add back the team type stuff and you should be good

@Zwendle Zwendle changed the base branch from develop to feature/recruitment_and_onboarding September 19, 2024 13:46
Copy link
Contributor

@Aaryan1203 Aaryan1203 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work lgtm!

@Aaryan1203 Aaryan1203 merged commit beb6fba into feature/recruitment_and_onboarding Sep 19, 2024
4 checks passed
@Aaryan1203 Aaryan1203 deleted the #2710-recruitment-create-acceptance-page branch September 19, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Recruitment] - Create Acceptance page
2 participants