New Change Request System Tests #2826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aaryan1203
reviewed
Sep 8, 2024
Comment on lines
+7
to
+37
| const SELECTORS = { | ||
| LOADING_INDICATOR: testIdBuilder('loader'), | ||
| LOGIN_ICON: testIdBuilder('LoginIcon'), | ||
| DEV_LOGIN_TEXT: 'Local Dev User', | ||
| CR_ROW: (title) => `[data-testid="${title}crRow"]`, | ||
| CR_ROW: (title) => testIdBuilder(`${title}crRow`), | ||
| NEW_CHANGE_REQUEST_BUTTON: 'New Change Request', | ||
| ALL_CHANGE_REQUESTS_TAB: 'All Change Requests', | ||
| CHANGE_REQUEST_TABLE: '[data-testid="Change Request Table"]' | ||
| CHANGE_REQUEST_TABLE: testIdBuilder('Change Request Table'), | ||
| PROJECT_OR_WORKPACKAGE_PLACEHOLDER: placeholderBuilder('Select a project or work package'), | ||
| ISSUE_BUTTON: 'ISSUE', | ||
| DEFINITION_CHANGE_BUTTON: 'DEFINITION_CHANGE', | ||
| OTHER_BUTTON: 'OTHER', | ||
| WHAT_DESCRIPTOR: 'What needs to be changed', | ||
| WHY_DESCRIPTOR: 'Why does this need to be changed', | ||
| WHY_TYPE_OPTION: (index) => `[name="why.${index}.type"]`, | ||
| WHY_EXPLAIN_TEXT_BOX: (index) => idBuilder(`why.${index}.explain-input`), | ||
| ADD_REASON: 'ADD REASON', | ||
| WHY_DELETE_OPTION: testIdBuilder('DeleteIcon'), | ||
| EXPLAIN_TEXT_BOX_PLACEHOLDER: placeholderBuilder('Explain *'), | ||
| ADD_PROPOSED_SOLUTION_BUTTON: '+ Add Solution', | ||
| PROPOSED_SOLUTION_DESCRIPTION_INPUT: idBuilder('description-input'), | ||
| PROPOSED_SOLUTION_SCOPE_INPUT: idBuilder('scopeImpact-input'), | ||
| PROPOSED_SOLUTION_BUDGET_INPUT: idBuilder('budgetImpact-input'), | ||
| PROPOSED_SOLUTION_TIMELINE_INPUT: idBuilder('timelineImpact-input'), | ||
| ADD_BUTTON: new RegExp('^Add$', 'g'), | ||
| SUBMIT_BUTTON: new RegExp('^Submit$', 'g'), | ||
| DIALOG: '[role="dialog"]', | ||
| ACTIONS_BUTTON: 'Actions', | ||
| ACTIONS_BUTTON_DELETE: 'Delete', | ||
| CONFIRM_DELETE_TEXT_INPUT: idBuilder('identifier-input'), | ||
| CHANGE_REQUEST_TITLE: new RegExp('Change Request #\\d+$') |
There was a problem hiding this comment.
Do you think we should create a different list of selectors for each type of test, that might be a little cleaner as this list would start getting rlly big
There was a problem hiding this comment.
yeah probably a good idea.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
System Tests For Creating a Change Request.
Theres an issue wher I could not figure out the change request number by like getting the title and then parsing out the number, i had it working at one point then it stopped working.
Checklist
It can be helpful to check the
ChecksandFiles changedtabs.Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.
yarn.lockchanges (unless dependencies have changed)Closes # (issue #)