Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2717 recruitment delete faqs and milestones #2783

Merged
merged 22 commits into from
Sep 11, 2024
Merged

#2717 recruitment delete faqs and milestones #2783

merged 22 commits into from
Sep 11, 2024

Conversation

superhvarn
Copy link
Contributor

@superhvarn superhvarn commented Sep 4, 2024 •
edited
Loading

Changes

  • Hooks for deleting FAQs and milestones
  • Generic modal for deleting items
  • Implemented generic modal for faq and milestone tables

Screenshots

Screenshot 2024-09-03 at 11 27 20 PM

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • No yarn.lock changes (unless dependencies have changed)
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes # (issue #2717 )

@superhvarn superhvarn linked an issue Sep 4, 2024 that may be closed by this pull request
[Recruitment] - Delete FAQs and Milestones #2717
Closed
Aaryan1203
Aaryan1203 requested changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@Aaryan1203 Aaryan1203 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Just left a couple comments to fix and it should be good

src/frontend/src/components/NERDeleteModal.tsx Outdated Show resolved Hide resolved
src/frontend/src/hooks/recruitment.hooks.ts Outdated Show resolved Hide resolved
src/frontend/src/pages/AdminToolsPage/RecruitmentConfig/FAQTable.tsx Outdated Show resolved Hide resolved
src/frontend/src/pages/AdminToolsPage/RecruitmentConfig/FAQTable.tsx Outdated Show resolved Hide resolved
src/frontend/src/pages/AdminToolsPage/RecruitmentConfig/FAQTable.tsx Outdated Show resolved Hide resolved
src/frontend/src/pages/AdminToolsPage/RecruitmentConfig/FAQTable.tsx Outdated Show resolved Hide resolved
src/frontend/src/pages/AdminToolsPage/RecruitmentConfig/MilestoneTable.tsx Outdated Show resolved Hide resolved
src/frontend/src/utils/urls.ts Outdated Show resolved Hide resolved
Aaryan1203
Aaryan1203 previously approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@Aaryan1203 Aaryan1203 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just the prettier check then lgtm

walker-sean
walker-sean requested changes Sep 6, 2024
View reviewed changes
src/frontend/src/components/NERDeleteModal.tsx Outdated Show resolved Hide resolved
src/frontend/src/pages/AdminToolsPage/RecruitmentConfig/FAQTable.tsx Outdated Show resolved Hide resolved
src/frontend/src/pages/AdminToolsPage/RecruitmentConfig/FAQTable.tsx Show resolved Hide resolved
src/frontend/src/pages/AdminToolsPage/RecruitmentConfig/FAQTable.tsx Outdated Show resolved Hide resolved
src/frontend/src/pages/AdminToolsPage/RecruitmentConfig/FAQTable.tsx Outdated Show resolved Hide resolved
src/frontend/src/pages/AdminToolsPage/RecruitmentConfig/FAQTable.tsx Outdated Show resolved Hide resolved
src/frontend/src/pages/AdminToolsPage/RecruitmentConfig/MilestoneTable.tsx Outdated Show resolved Hide resolved
src/frontend/src/pages/AdminToolsPage/RecruitmentConfig/MilestoneTable.tsx Outdated Show resolved Hide resolved
src/frontend/src/pages/AdminToolsPage/RecruitmentConfig/MilestoneTable.tsx Show resolved Hide resolved
@walker-sean walker-sean merged commit 1b2023b into develop Sep 11, 2024
4 checks passed
@walker-sean walker-sean deleted the 2717-recruitment-delete-faqs-and-milestones branch September 11, 2024 00:35
@superhvarn superhvarn changed the title 2717 recruitment delete faqs and milestones @2717 recruitment delete faqs and milestones Sep 11, 2024
@superhvarn superhvarn changed the title @2717 recruitment delete faqs and milestones #2717 recruitment delete faqs and milestones Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@walker-sean walker-sean walker-sean approved these changes

@Aaryan1203 Aaryan1203 Aaryan1203 left review comments

Assignees

@superhvarn superhvarn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Recruitment] - Delete FAQs and Milestones
4 participants
@superhvarn @Aaryan1203 @walker-sean @RChandler234