Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Recruitment] - #2712 pnm homepage #2760

Merged
merged 36 commits into from
Sep 13, 2024

Conversation

Aaryan1203
Copy link
Contributor

@Aaryan1203 Aaryan1203 commented Aug 23, 2024

Changes

Created PNM home page
Added apply button to sidebar
Updated tabs component to abstract finance tabs and normal tabs
Added our recruitment section with updated tabs

Screenshots

image
image

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • No yarn.lock changes (unless dependencies have changed)
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes #2712

@Aaryan1203 Aaryan1203 self-assigned this Aug 23, 2024
Copy link
Contributor

@Peyton-McKee Peyton-McKee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If i go to teams and then press home again, it brings me back to the original home screen, not the pnm one. Seems like that flow needs to be worked out a bit more. Maybe reach out to Naisha to iron out the flow between the different home screens.

src/frontend/src/hooks/organizations.hooks.ts Outdated Show resolved Hide resolved
src/frontend/src/components/NERTabs.tsx Outdated Show resolved Hide resolved
src/frontend/src/hooks/organizations.hooks.ts Show resolved Hide resolved
src/frontend/src/layouts/Sidebar/Sidebar.tsx Outdated Show resolved Hide resolved
src/frontend/src/components/Tabs.tsx Outdated Show resolved Hide resolved
src/frontend/src/pages/HomePage/PNMHomePage.tsx Outdated Show resolved Hide resolved
src/frontend/src/pages/HomePage/PNMHomePage.tsx Outdated Show resolved Hide resolved
@Aaryan1203 Aaryan1203 changed the base branch from develop to feature/recruitment_and_onboarding September 8, 2024 20:30
@Aaryan1203 Aaryan1203 changed the title #2712 pnm homepage [Recruitment] - #2712 pnm homepage Sep 8, 2024
Copy link
Contributor

@Peyton-McKee Peyton-McKee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, it was my mistake for trying to do this without just having them be routed to different url pages. This seems to be signifcantly more complicated than just switching them in the router

system-tests/cypress/e2e/pnm-page/pnm-home-page.cy.js Outdated Show resolved Hide resolved
system-tests/cypress/e2e/homepage/home-page.cy.js Outdated Show resolved Hide resolved
system-tests/cypress/e2e/homepage/home-page.cy.js Outdated Show resolved Hide resolved
src/frontend/src/pages/TeamsPage/TeamSummary.tsx Outdated Show resolved Hide resolved
src/frontend/src/app/HomePageContext.tsx Outdated Show resolved Hide resolved
@walker-sean walker-sean merged commit 9e7b361 into feature/recruitment_and_onboarding Sep 13, 2024
4 checks passed
@walker-sean walker-sean deleted the #2712-pnm-homepage branch September 13, 2024 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Recruitment] - Create PNM Mode Homepage
3 participants