-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Recruitment] - #2712 pnm homepage #2760
[Recruitment] - #2712 pnm homepage #2760
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If i go to teams and then press home again, it brings me back to the original home screen, not the pnm one. Seems like that flow needs to be worked out a bit more. Maybe reach out to Naisha to iron out the flow between the different home screens.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, it was my mistake for trying to do this without just having them be routed to different url pages. This seems to be signifcantly more complicated than just switching them in the router
src/frontend/src/pages/FinancePage/FinanceComponents/ReimbursementRequestInfo.tsx
Outdated
Show resolved
Hide resolved
src/frontend/src/pages/FinancePage/FinanceComponents/ReimbursementRequestInfo.tsx
Outdated
Show resolved
Hide resolved
9e7b361
into
feature/recruitment_and_onboarding
Changes
Created PNM home page
Added apply button to sidebar
Updated tabs component to abstract finance tabs and normal tabs
Added our recruitment section with updated tabs
Screenshots
Checklist
It can be helpful to check the
Checks
andFiles changed
tabs.Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.
yarn.lock
changes (unless dependencies have changed)Closes #2712