Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2708 Hook up edit and create team type modals and upload team type image #2731

Merged
merged 49 commits into from
Oct 4, 2024
Merged

#2708 Hook up edit and create team type modals and upload team type image #2731

merged 49 commits into from
Oct 4, 2024

Conversation

Aaryan1203
Copy link
Contributor

@Aaryan1203 Aaryan1203 commented Jul 23, 2024 •
edited
Loading

Changes

  • Added description and image field to team type schema
  • Added edit team type endpoint
  • Added unit tests for updating description
  • Created endpoint for updating images
  • unit tests for updating images
  • Created edit team type hook
  • Hooked up edit team type to frontend
  • Can upload an image for a team type

Test Cases

Screenshot 2024-07-23 at 3 28 16 PM Screenshot 2024-07-23 at 3 28 34 PM Screenshot 2024-07-24 at 1 27 23 PM image image

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • No yarn.lock changes (unless dependencies have changed)
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes #2708

@Aaryan1203 Aaryan1203 self-assigned this Jul 23, 2024
walker-sean
walker-sean requested changes Jul 25, 2024
View reviewed changes
Copy link
Member

@walker-sean walker-sean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good overall - just remember to rename everything in the backend

src/backend/src/prisma/schema.prisma Outdated Show resolved Hide resolved
src/backend/src/prisma/seed.ts Outdated Show resolved Hide resolved
src/backend/src/services/teams.services.ts Outdated Show resolved Hide resolved
src/backend/src/services/teams.services.ts Outdated Show resolved Hide resolved
src/backend/src/services/teams.services.ts Outdated Show resolved Hide resolved
walker-sean
walker-sean requested changes Aug 1, 2024
View reviewed changes
Copy link
Member

@walker-sean walker-sean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice so far, some small things

src/backend/src/services/teams.services.ts Show resolved Hide resolved
src/backend/src/services/teams.services.ts Show resolved Hide resolved
src/frontend/src/pages/AdminToolsPage/TeamConfig/CreateTeamTypeFormModal.tsx Outdated Show resolved Hide resolved
src/frontend/src/pages/AdminToolsPage/TeamConfig/TeamTypeFormModal.tsx Outdated Show resolved Hide resolved
src/frontend/src/pages/AdminToolsPage/TeamConfig/TeamTypeFormModal.tsx Show resolved Hide resolved
src/frontend/src/pages/AdminToolsPage/TeamConfig/TeamTypeFormModal.tsx Outdated Show resolved Hide resolved
@Aaryan1203 Aaryan1203 changed the title #2708 added description field to team type and cerated edit team type endpoint #2708 Hook up edit and create team type modals and upload team type image Aug 18, 2024
@walker-sean walker-sean merged commit 432fceb into develop Oct 4, 2024
4 checks passed
@walker-sean walker-sean deleted the #2708-edit-team-type-description-endpoint branch October 4, 2024 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Peyton-McKee Peyton-McKee Peyton-McKee left review comments

@walker-sean walker-sean walker-sean approved these changes

Assignees

@Aaryan1203 Aaryan1203

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Recruitment] - Edit Team type schema
4 participants
@Aaryan1203 @Peyton-McKee @walker-sean @superhvarn