Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1606 archivable teams adjust frontend #2672

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from

Conversation

superhvarn
Copy link
Contributor

@superhvarn superhvarn commented Jun 17, 2024

Changes

  • Archiving team buttons in actions menu
  • Chip on team specific page for archived or unarchived

Screenshots

Screenshot 2024-06-17 at 5 11 02 PM Screenshot 2024-06-17 at 5 13 05 PM

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • No yarn.lock changes (unless dependencies have changed)
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes # (issue #1606 )

@superhvarn superhvarn linked an issue Jun 17, 2024 that may be closed by this pull request
6 tasks
Copy link
Contributor

@Aaryan1203 Aaryan1203 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SMall changed

src/frontend/src/pages/TeamsPage/TeamSpecificPage.tsx Outdated Show resolved Hide resolved
src/frontend/src/pages/TeamsPage/TeamSpecificPage.tsx Outdated Show resolved Hide resolved
Copy link
Member

@walker-sean walker-sean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the separate sections for teams!

src/backend/src/services/teams.services.ts Outdated Show resolved Hide resolved
src/frontend/src/apis/teams.api.ts Show resolved Hide resolved
export const useAllTeams = () => {
return useQuery<Team[], Error>(['teams'], async () => {
const { data } = await getAllTeams();
export const useAllTeams = (onlyArchive: boolean) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment here about splitting things up or making the distinction when rendering

</NERButton>
);

const TeamActionsDropdown = () => (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't have to use buttons in the dropdown itself - you can model the dropdown after the project actions dropdown to see how we typically do it

src/frontend/src/pages/TeamsPage/TeamSpecificPage.tsx Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Archivable Teams - Adjust Frontend
3 participants