#83 - ADS131M04 Driver #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 2, 2024 22:26
nwdepatie
requested changes
Apr 7, 2024
nwdepatie
requested changes
Apr 12, 2024
There was a problem hiding this comment.
Ngl i'm a lil confused about how a dev might interact with this API. An ideal driver willmake it so that the user doesn't have to read the data sheet at all for how data is formatted in the registers and such. Also the SPI transactions are a bit off, check comment
general/src/ADS131M04.c
Outdated
| void ads131m04_send_command(ads131_t *adc, uint16_t cmd) | ||
| { | ||
| HAL_GPIO_WritePin(adc->gpio, adc->cs_pin, GPIO_PIN_RESET); | ||
| HAL_SPI_Transmit(adc->spi, cmd, 1, HAL_MAX_DELAY); |
There was a problem hiding this comment.
So usually you gotta write the register and value in 1 set of transactions (i.e. set pin low, write spi, write spi, ... set pin high)
|
|
nwdepatie
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The basic interface for the driver, setting up some basic SPI, and initializing the ADC into continuous-conversion mode using the RESET command. Mainly trying to figure out whether I need to configure anything to get good readings from the ADC and the best way to read out the values generated by the ADC
Notes
data-ready interrupt signal, DRDY
The end of tPOR is indicated by a transition of DRDY from low to high. The transition of DRDY from low to
high also indicates the SPI interface is ready to accept commands.
Connect the DRDY pin to a digital input on the host to trigger periodic data retrieval in conversion mode.
The conversion status of all channels is available as the DRDY[3:0] bits in the
STATUS register. The STATUS register content is automatically output as the response to the NULL command.
SPI: The device defaults to a 24-bit word size.
Either strobe the SYNC/RESET pin to re-synchronize conversions and clear the
FIFOs, or quickly read two data packets when data are read for the first time or after a gap in reading data.
This process ensures predictable DRDY pin behavior.
Notes for self from data sheet:
Might be important:
Todo
Checklist
It can be helpful to check the
ChecksandFiles changedtabs.Please reach out to your Project Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.
Closes #83