Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing serial print #215

Merged
merged 4 commits into from
Nov 7, 2024
Merged

Removing serial print #215

merged 4 commits into from
Nov 7, 2024

Conversation

jr1221
Copy link
Contributor

@jr1221 jr1221 commented Oct 27, 2024

It is hella inconsistent, and not needed. IMO we shouldnt print much permanently anyway. Plus the USART DMA PR would obsolete this anyway.

So lets yeet it.

@jr1221 jr1221 marked this pull request as ready for review November 5, 2024 03:58
@jr1221 jr1221 requested a review from Sabramz November 5, 2024 03:58
Sabramz
Sabramz approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@Sabramz Sabramz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Find and replace OP

@Sabramz Sabramz merged commit fa0539d into develop Nov 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sabramz Sabramz Sabramz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jr1221 @Sabramz