Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#10-CRUD-upsert-dataTypes-revamp #54

Merged
merged 4 commits into from
Oct 6, 2023

Conversation

RadiantBunny633
Copy link
Contributor

Changes

Added the service function that will upsert the dataTypes along with testing to ensure it works. I also had to add a command to the node test just so I can get the tests to pass.

To Do

Any remaining things that need to get done

  • whatever is left for the CRUD ops

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • No package-lock.json changes (unless dependencies have changed)
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes #10

…g for the function. Also slightly altered the node test so that the tests run without issue.
Copy link
Contributor

@Peyton-McKee Peyton-McKee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice job just some comments on testing

scylla-server/tests/dataTypes-services.test.ts Outdated Show resolved Hide resolved
scylla-server/tests/dataTypes-services.test.ts Outdated Show resolved Hide resolved
scylla-server/tests/dataTypes-services.test.ts Outdated Show resolved Hide resolved
scylla-server/tests/nodes-services.test.ts Outdated Show resolved Hide resolved
@Peyton-McKee Peyton-McKee merged commit 2814e06 into main Oct 6, 2023
4 checks passed
@Peyton-McKee Peyton-McKee deleted the #10-CRUD-upsert-dataTypes-revamp branch October 6, 2023 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CRUD Operations - Upsert DataType
2 participants