Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#16 CRUD get data by datatype name #39

Merged
merged 11 commits into from
Sep 27, 2023

Conversation

leoleader
Copy link

Changes

  • Added getDataByDataTypeName CRUD Operation
  • Added unit test for above
  • Made Type ResponseFunction's data:JSON input required
    • Originally I opted for it to be optional but I think as design decision it's important for it to be required
  • Updated unit tests accordingly with above

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • No package-lock.json changes (unless dependencies have changed)
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes # 16

@leoleader leoleader linked an issue Sep 25, 2023 that may be closed by this pull request
2 tasks
Copy link
Contributor

@Peyton-McKee Peyton-McKee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice job, you can do it this way, idk if we should make the data be nonoptional though,

scylla-server/src/services/data.services.ts Outdated Show resolved Hide resolved
scylla-server/src/services/data.services.ts Outdated Show resolved Hide resolved
scylla-server/src/services/data.services.ts Outdated Show resolved Hide resolved
scylla-server/tests/data-services.test.ts Show resolved Hide resolved
scylla-server/tests/dataTypes-services.test.ts Outdated Show resolved Hide resolved
scylla-server/src/utils/message-maps.utils.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@Peyton-McKee Peyton-McKee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see slack about type validating

scylla-server/tests/data-services.test.ts Outdated Show resolved Hide resolved
scylla-server/tests/data-services.test.ts Outdated Show resolved Hide resolved
scylla-server/tests/data-services.test.ts Outdated Show resolved Hide resolved
scylla-server/tests/data-services.test.ts Outdated Show resolved Hide resolved
scylla-server/tests/data-services.test.ts Show resolved Hide resolved
Peyton-McKee
Peyton-McKee previously approved these changes Sep 27, 2023
Copy link
Contributor

@Peyton-McKee Peyton-McKee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets goooo

@Peyton-McKee Peyton-McKee merged commit 1735ef5 into main Sep 27, 2023
4 checks passed
@Peyton-McKee Peyton-McKee deleted the 16-crud-operations-get-data-by-datatype-name branch September 27, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CRUD Operations - Get Data By DataType Name
2 participants