#24-CRUD-upsert-driver #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Peyton-McKee
requested changes
Sep 21, 2023
| * CRUD operation to create a driver in the database if it doesn't already exist, does nothing otherwise. | ||
| * | ||
| */ | ||
| export const upsertDriver = async (driver_name: string) => { |
There was a problem hiding this comment.
we dont user _ really, should be camel case
There was a problem hiding this comment.
I see i see changing it rn.
| */ | ||
| test('Get All Data Types Works', async () => { | ||
| const expected = [{ username: 'test' }]; | ||
| const result = await getAllDrivers(); |
There was a problem hiding this comment.
this isnt going to pass because it doesnt exist in the database yet
I think this should fix the test issue
Fixed it so that it camel cases
Im trolling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
I added the service function for upsertDriver and in order to test this we needed to call a getAllDrivers type of service function so I made that as well. I also added testing for both of the service functions I added and lastly I added the getAllDrivers to the message map.
Notes
The tests were running fine in the terminal I'm gonna try to figure out why its not working here.
To Do
Any remaining things that need to get done
Checklist
It can be helpful to check the
ChecksandFiles changedtabs.Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.
package-lock.jsonchanges (unless dependencies have changed)Closes #24