Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#23 Upsert System #31

Merged
merged 3 commits into from
Sep 19, 2023
Merged

#23 Upsert System #31

merged 3 commits into from
Sep 19, 2023

Conversation

leoleader
Copy link

Changes

  • Created service function for upserting system
  • Created 2 unit tests for this service function
  • Slightly modified typing and unit test for previous getAllSystems function

Notes

Since this is currently a private function that's not connected to client I just made it a void function
that takes in a string pertaining to the name of the system.

Test Cases

  • Upserting a system that does not exist
  • Upserting a system that does exist

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • [ x] All commits are tagged with the ticket number
  • [ x] No linting errors / newline at end of file warnings
  • [x ] All code follows repository-configured prettier formatting
  • [ x] No merge conflicts
  • [ x] All checks passing
  • [ x] Screenshots of UI changes (see Screenshots section)
  • [x ] Remove any non-applicable sections of this template
  • [ x] Assign the PR to yourself
  • [ x] No package-lock.json changes (unless dependencies have changed)
  • [x ] Request reviewers & ping on Slack
  • [ x] PR is linked to the ticket (fill in the closes line below)

Closes # 23

@leoleader leoleader self-assigned this Sep 19, 2023
@leoleader leoleader linked an issue Sep 19, 2023 that may be closed by this pull request
Copy link
Contributor

@Peyton-McKee Peyton-McKee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

W job on this

scylla-server/src/services/systems.services.ts Outdated Show resolved Hide resolved
scylla-server/tests/systems-services.test.ts Outdated Show resolved Hide resolved
scylla-server/tests/systems-services.test.ts Outdated Show resolved Hide resolved
scylla-server/src/services/systems.services.ts Outdated Show resolved Hide resolved
scylla-server/src/services/systems.services.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@Peyton-McKee Peyton-McKee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

W

@Peyton-McKee Peyton-McKee merged commit c3f29f0 into main Sep 19, 2023
4 checks passed
@Peyton-McKee Peyton-McKee deleted the #23-CRUD-upsert-system branch September 19, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CRUD Operations - Upsert System
2 participants