#9 - CRUD get all data types #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Peyton-McKee
requested changes
Sep 17, 2023
| { id: 2, dataType: 'int' } | ||
| ]; | ||
| const prismaMock = require('../prisma/prisma-client'); | ||
| prismaMock.dataType.findMany.mockResolvedValue(expected); |
There was a problem hiding this comment.
no you dont need to mock these because were using an sqlite db which is included in github so we actually wanna test our prisma calls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Added the service function which will return all the data types in the base.
Notes
I had a few issues but I think what I'm submitting here is much better than what I was submitting yesterday. Yesterday, for some reason my vs code was not updating the ncode so I wasn't updating the map correctly. However, once this was figured out my other issue was just submitting. Apologies in advance for creating another pull request rather than committing on the other one. I was having an issue actually getting these new changes to that other ticket. However, the creation of this new ticket allowed me to get my changes to go through so if possible could ticket #28 perhaps be deleted? Ok I also am not sure what on earth those 3200 changes are.
Update: I think I fixed it.
To Do
Any remaining things that need to get done
Checklist
It can be helpful to check the
ChecksandFiles changedtabs.Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.
package-lock.jsonchanges (unless dependencies have changed)Closes #9