-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#195 Reactive Toast Button #218
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RChandler234
requested changes
Oct 8, 2024
angular-client/src/components/argos-button/argos-button.component.ts
Outdated
Show resolved
Hide resolved
RChandler234
requested changes
Oct 24, 2024
RChandler234
requested changes
Oct 27, 2024
angular-client/src/components/toast-button/toast-button.component.ts
Outdated
Show resolved
Hide resolved
toasts successes and errors because how we handle posts right now doesn't allow us to catch the error from the frontend as cleanly as we do in FinishLine, cleaning up in another ticket |
RChandler234
approved these changes
Oct 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🔥
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Added a more interactive design for the "Start New Run" button which also displays a toast for successfully running said task.
Notes
Could be utilized for future buttons that require toast message pop-ups. Note that the current setting for this button has it so that the background color is red, so would need readjustment of style and the type of toast pop-up.
Test Cases
See screenshots.
Screenshots
To Do
Any remaining things that need to get done
Checklist
It can be helpful to check the
Checks
andFiles changed
tabs.Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.
package-lock.json
changes (unless dependencies have changed)Closes #195 (issue #)