Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#195 Reactive Toast Button #218

Merged
merged 9 commits into from
Oct 27, 2024
Merged

Conversation

emirdur
Copy link
Contributor

@emirdur emirdur commented Sep 29, 2024

Changes

Added a more interactive design for the "Start New Run" button which also displays a toast for successfully running said task.

Notes

Could be utilized for future buttons that require toast message pop-ups. Note that the current setting for this button has it so that the background color is red, so would need readjustment of style and the type of toast pop-up.

Test Cases

See screenshots.

Screenshots

hover clicked

To Do

Any remaining things that need to get done

  • Remove the import "import { ToastService } from 'src/app/toast.service';" from "src/components/argos-button/argos-button.component.ts"
  • Merge the argos button and toast button components into one by specifying the message, etc. but still needs talking through

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • No package-lock.json changes (unless dependencies have changed)
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes #195 (issue #)

@emirdur emirdur self-assigned this Sep 29, 2024
angular-client/package.json Outdated Show resolved Hide resolved
angular-client/src/app/app-routing.module.ts Outdated Show resolved Hide resolved
angular-client/src/app/app.module.ts Outdated Show resolved Hide resolved
@RChandler234
Copy link
Contributor

RChandler234 commented Oct 27, 2024

toasts successes and errors because how we handle posts right now doesn't allow us to catch the error from the frontend as cleanly as we do in FinishLine, cleaning up in another ticket

Copy link
Contributor

@RChandler234 RChandler234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

@RChandler234 RChandler234 merged commit 494b8f7 into develop Oct 27, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Client] - Visually Interactable Button with Pop-up
2 participants