Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#15 - CRUD get all systems #21

Merged
merged 6 commits into from
Sep 14, 2023
Merged

#15 - CRUD get all systems #21

merged 6 commits into from
Sep 14, 2023

Conversation

leoleader
Copy link

Changes

added service function for get all systems

Notes

currently just returning result from findMany as json, not entirely sure if that's the desired
way to return resulting data for this so would like feedback

Test Cases

  • Haven't decided on unit testing for this yet

To Do

  • [] Unit testing (maybe)

@leoleader leoleader linked an issue Sep 13, 2023 that may be closed by this pull request
2 tasks
scylla-server/src/index.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@Peyton-McKee Peyton-McKee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lit Job! Left a few comments.

scylla-server/src/services/systems.services.ts Outdated Show resolved Hide resolved
scylla-server/src/utils/message-maps.utils.ts Outdated Show resolved Hide resolved
scylla-server/src/utils/message-maps.utils.ts Outdated Show resolved Hide resolved
scylla-server/src/utils/message-maps.utils.ts Outdated Show resolved Hide resolved
scylla-server/src/services/systems.services.ts Outdated Show resolved Hide resolved
scylla-server/src/services/systems.services.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@Peyton-McKee Peyton-McKee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WWWWW

@Peyton-McKee Peyton-McKee merged commit a1e3ccc into main Sep 14, 2023
4 checks passed
@Peyton-McKee Peyton-McKee deleted the #15-CRUD-get-all-systems branch September 26, 2023 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CRUD Operations - Get All Systems
2 participants