Scylla Calypso #173
Merged
Scylla Calypso #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RChandler234
requested changes
Aug 2, 2024
| info!( | ||
| "A cleanup batch uploaded: {:?}", | ||
| data_service::add_many(&database, final_msgs).await | ||
| ); |
There was a problem hiding this comment.
what's this code doing?
There was a problem hiding this comment.
That code batch uploads all remaining batches before exiting, such that scylla will not exit until all batch uploads are complete.
basically I noticed I used a loop and the proper rust syntax is a while and it annoyed me so much I switched it in this PR even though this PR is unrelated. my b.
if calypso receives a short or emtpy protobuf command_data, it will fill the extra values with the default value specified in the YAML. so we should allow the client to specify blank which could end up meaning a "Reset to Default" button.
RChandler234
requested changes
Aug 9, 2024
jr1221
added a commit
that referenced
this pull request
Sep 16, 2024
* basic proof of concept * misc improvements and cleanup of cursory processing * implement reids review suggestions * try and fix clippy * and again fix clippy * make data query optional to reset calypso to default if calypso receives a short or emtpy protobuf command_data, it will fill the extra values with the default value specified in the YAML. so we should allow the client to specify blank which could end up meaning a "Reset to Default" button. * clippy is trolling me * fixup error handling for plaintext error message * implement reid fixes * remove not prod error
jr1221
added a commit
that referenced
this pull request
Sep 16, 2024
* basic proof of concept * misc improvements and cleanup of cursory processing * implement reids review suggestions * try and fix clippy * and again fix clippy * make data query optional to reset calypso to default if calypso receives a short or emtpy protobuf command_data, it will fill the extra values with the default value specified in the YAML. so we should allow the client to specify blank which could end up meaning a "Reset to Default" button. * clippy is trolling me * fixup error handling for plaintext error message * implement reid fixes * remove not prod error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
config/<key>?data=123&data=456. For context, this sends a MQTT message in accordance with the specifications of this PR.Notes
Do yall have any recommendations on how error codes and whatnot should be handled in the web server side? Should an error message be returned in the body of the response, or should we just have error codes and a log of what happened internal to the server?
Test Cases
candumping a virtual can interfaceChecklist
It can be helpful to check the
ChecksandFiles changedtabs.Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.
package-lock.jsonchanges (unless dependencies have changed)