Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scylla Server in Rust #171

Merged
merged 68 commits into from
Sep 16, 2024
Merged

Scylla Server in Rust #171

merged 68 commits into from
Sep 16, 2024

Conversation

jr1221
Copy link
Contributor

@jr1221 jr1221 commented Jul 23, 2024 •
edited
Loading

This adds a whole lot.

The new folder scylla-server-rust contains a complete scylla implementation in rust. Functional differences to the JS one:

  • Implements a Latency key to see latency to server
  • Implements a POST runs/new endpoint for creating a new run
  • Adds logging via env vars (see README)
  • Changes names, types and defaults of some other setting env vars (see bottom of README)
  • Implements the bidirectional functionality

Stuff outside of the scylla-server-rust scope:

  • Add docker compose profile logic to apply various system configurations quickly, with accompanying argos.sh
  • github workflows to build argos-client and argos-scylla seperately
  • Root README updates for all of the above.
  • Adds persistence mode to mosquitto to allow seamless resubscription in case of reconnection of scylla

@jr1221 jr1221 self-assigned this Aug 24, 2024
@jr1221 jr1221 marked this pull request as ready for review August 28, 2024 20:30
Peyton-McKee
Peyton-McKee previously approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@Peyton-McKee Peyton-McKee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YIPPPEEEE

@jr1221 jr1221 mentioned this pull request Sep 14, 2024
Open
RChandler234
RChandler234 requested changes Sep 16, 2024
View reviewed changes
compose.yml Outdated Show resolved Hide resolved
scylla-server-rust/src/controllers/data_controller.rs Outdated Show resolved Hide resolved
scylla-server-rust/src/main.rs Outdated Show resolved Hide resolved
scylla-server-rust/integration_test.sh Outdated Show resolved Hide resolved
@jr1221
fix client, remove macos build as license wrong
fa469dc
@jr1221
misc fixes, reconnect logic fix in siren and timestamp logic fix
5061c8f
@jr1221
instructions and feature config for tokio-console top
85c42b8
@jr1221
add latency send 0.25 seconds 20 message ringbuffer
17cff48
@jr1221
add new run, fix some error handling and prints, add axum trace
716677b
@jr1221
add cargo prisma-seed
ecbb588
@jr1221
remedy clippy (for some reason gone on local)
7c3d19c
@jr1221
run on push once
87f6518
@jr1221
misc compose fixups
5a615e6
@jr1221
change db name to postgres
bfda4e0
@jr1221
add docker help scripts, clap cli and more settings to batching
7f44f43
@jr1221
Scylla Calypso (#173)
174a651 
* basic proof of concept

* misc improvements and cleanup of cursory processing

* implement reids review suggestions

* try and fix clippy

* and again fix clippy

* make data query optional to reset calypso to default

if calypso receives a short or emtpy protobuf command_data, it will fill the extra values with the default value specified in the YAML. so we should allow the client to specify blank which could end up meaning a "Reset to Default" button.

* clippy is trolling me

* fixup error handling for plaintext error message

* implement reid fixes

* remove not prod error
@jr1221
rename misleading script, fix some docs
3e63d0a
@jr1221
add tokenized halt of mqtt processor to prevent race conditions
78ceca3
@jr1221
ignore yaml
4aaa5ee
@jr1221
add one missing doc
6b2b159
@jr1221
update compose
f126c48
@jr1221
fix typo
876239e
@jr1221
flag to disable batch uploading
6ec3c6a
@jr1221
add simple socket discarding
df5d935
@jr1221
fix docs
df5b8de
@jr1221
remove last will
7a3d239
@jr1221
add brick
15347e7
@jr1221
fix brick
92563d5
@jr1221
rename scylla-server-rust to scylla-server
6c18461
@jr1221
add comments, fix tests, rename more files, fix ci
f0956c2
@jr1221 jr1221 merged commit a61204e into develop Sep 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RChandler234 RChandler234 RChandler234 requested changes

@Peyton-McKee Peyton-McKee Peyton-McKee left review comments

Assignees

@jr1221 jr1221

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jr1221 @RChandler234 @Peyton-McKee