Updated documentation and a few code changes #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Verdanix
commented
Nov 17, 2024
Verdanix
commented
- Added README.md for each module's API usage.
- Changed TomlConfiguration to use generics to remove the necessary casting when getting the config object
- Updated Javadoc comments
- Added a maven execution goal to install sherpa-onnx instead of having to do it manually. It now does it automatically.
- Removed the need for wget in the GH action workflow to
- Automated downloading and installing of sherpa-onnx for building and testing - Created package-info.java for nora-configuration
I need some Java right now. Too long of a day
I need some Java right now. Too long of a day
…ts out promising and ends up in complete failure where I wonder why I'm even doing this
And all you have to do is look at the GH action logs -_-
- Added Generics to TomlConfiguration - Changed loggerName to loggerFileDirName in LoggerConfiguration - Added api-usage docs for each module in the form of a README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.