#161 Express 4 support: edit and launch www file

Nodeclipse · Sep 25, 2014 · 22fd0e1 · 22fd0e1
1 parent 09a31ac
commit 22fd0e1
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 3 deletions.
diff --git a/org.nodeclipse.debug/plugin.xml b/org.nodeclipse.debug/plugin.xml
@@ -126,6 +126,11 @@
                           <test   
                                 property= "org.eclipse.debug.ui.matchesPattern"   
                                 value= "*.njs" >   
+                          </test>
+                          <!-- for Express 4.x -->   
+                          <test   
+                                property= "org.eclipse.debug.ui.matchesPattern"   
+                                value= "www" >   
                           </test>   
                        </or>   
                     </iterate>   

diff --git a/org.nodeclipse.debug/src/org/nodeclipse/debug/launch/LaunchConfigurationDelegate.java b/org.nodeclipse.debug/src/org/nodeclipse/debug/launch/LaunchConfigurationDelegate.java
@@ -137,8 +137,10 @@ public void launch(ILaunchConfiguration configuration, String mode,
 		if(i > 0) {
 			extension = file.substring(i+1);
 		} else {
-			throw new CoreException(new Status(IStatus.OK, ChromiumDebugPlugin.PLUGIN_ID,
-				"Target file does not have extension: " + file, null));
+			//			throw new CoreException(new Status(IStatus.OK, ChromiumDebugPlugin.PLUGIN_ID,
+			//				"Target file does not have extension: " + file, null));
+			// by default assume
+			extension = "js";
 		}
 
 		// #57 running app.js with node-dev, forever, supervisor, nodemon etc

diff --git a/org.nodeclipse.ui/plugin.xml b/org.nodeclipse.ui/plugin.xml
@@ -86,6 +86,14 @@
             id="org.nodeclipse.ui.editors.NodeEditor"
             name="Nodeclipse JSDT-based Editor">
       </editor>
+      <editor
+            class="org.nodeclipse.ui.editors.NodeEditor"
+            contributorClass="org.eclipse.ui.texteditor.BasicTextEditorActionContributor"
+            filenames = "www"
+            icon="icons/node_red.png"
+            id="org.nodeclipse.ui.editors.NodeEditor"
+            name="Nodeclipse JSDT-based Editor">
+      </editor>
       <!-- just for different icons for json,jshintrc -->
       <editor 
             class="org.nodeclipse.ui.editors.NodeEditor"
@@ -94,7 +102,7 @@
             extensions="json,jshintrc,tern-project"
             icon="icons/node_blue.png"
             id="org.nodeclipse.ui.editors.NodeEditor"
-            name="Nodeclipse JSDT Editor">
+            name="Nodeclipse JSDT-based Editor">
       </editor>
       <!-- class is not on plugin classpath!
       <editor