Datamapper support

[fzagarzazu]

DataMapper Support

Passed tests with DM adapter: dm-mysql-adapter .

Please see notes in README file, code review and feedback appreciated.

[kirs]

Why do we need redis adapter here?
As mysql database is created on Travis, do we need dm-sqlite as well?

[fzagarzazu]

The adapters for redis and sqlite are there because I was using them for testing during development, I left the redis setup commented out in spec/orm/datamapper.rb just in case somebody wanted to use it.
We can remove them.

[kirs]

Now it's better 😉
But I still don't feel comfortable to override the save method inside the gem.

What do you think about writing method like update_many_attributes (which is especially to be capable with all ORMs), but for saving without validation?

[fzagarzazu]

Something like this ?

          # lib/sorcery/model/adapters/datamapper.rb 
          def sorcery_save(mthd, options = {})
            if options.key?(:validate) && ! options[:validate]
              save!
            else
              save
            end
          end

         # other adapters
          def sorcery_save(mthd, options = {})
            self.send(mthd, options)
          end

[kirs]

I'm not sure we need mthd (it stands method_name as I understood), but you've got the main idea.

[kirs]

Could you rebase it, please?

[fzagarzazu]

Updated, expected to work with Rails 3, datamapper is not being actively developed.

[kirs]

That means after merging Datamapper integration we'll always have red status on Travis. Any ideas how to avoid it?

[fzagarzazu]

Added an exclusion filter to skip DM tests