Upgrade nixpkgs take 2 #40
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stoeffel
reviewed
Apr 11, 2022
| in case Aeson.eitherDecode' str of | ||
| Prelude.Left err -> Err (Text.fromList err) | ||
| Prelude.Right (json :: Aeson.Value) -> | ||
| Data.Aeson.Encode.Pretty.encodePretty' config json |
stoeffel
reviewed
Apr 11, 2022
| @@ -5,18 +5,9 @@ let | |||
| in import nix/mk-shell.nix { | |||
| pkgs = pkgs; | |||
| haskellPackages = pkgs.haskell.packages.ghc8107.extend (self: super: { | |||
| semialign = super.semialign_1_2_0_1; | |||
There was a problem hiding this comment.
Nice that we now can just use what's on nixpkgs!
rekahsoft
added
the
Hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A second take on #27
In e360a47 this PR adds key-comparison for our use of aeson-pretty so its generated JSON has consistently ordered keys. This should protect us somewhat against future reordering of key/value pairs. It also serves as "proof" that the generated outputs did not change in any commits after e2a86c9
CC @stoeffel