Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: error raised for short series #31

Merged
merged 1 commit into from
Oct 14, 2024
Merged

hotfix: error raised for short series #31

merged 1 commit into from
Oct 14, 2024

Conversation

MMenchero
Copy link
Collaborator

Description

This hotfix removes an error that shouldn't be raised when dealing with short series. The original code included this:

if (any(input_samples > num_rows$initial_size)){
      stop(paste0("Your time series is too short. Please make sure that each of your series contains at least ", model_params$input_size+model_params$horizon, " observations."))
}

This part was added to prevent some unique ids from disappearing when using dplyr::slice_tail(). However, this is not necessary since the documentation of this function says that indices beyond the number of rows in the input are silently ignored. Furthermore, this was preventing some users from generating a forecast when the Python SDK had raised no issues for the same case.

@MMenchero MMenchero added the bug Something isn't working label Oct 14, 2024
@MMenchero MMenchero changed the title hotfix: error for short series hotfix: error raised for short series Oct 14, 2024
@MMenchero MMenchero merged commit a9ac12b into master Oct 14, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant