hotfix: error raised for short series #31
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This hotfix removes an error that shouldn't be raised when dealing with short series. The original code included this:
This part was added to prevent some unique ids from disappearing when using
dplyr::slice_tail()
. However, this is not necessary since the documentation of this function says that indices beyond the number of rows in the input are silently ignored. Furthermore, this was preventing some users from generating a forecast when the Python SDK had raised no issues for the same case.