Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make season_length optional in AutoMLForecast #399

Merged
merged 1 commit into from
Aug 12, 2024
Merged

Conversation

jmoralez
Copy link
Member

@jmoralez jmoralez commented Aug 12, 2024

Description

The season_length is only used for generating a feature space, if the user is already providing an init_config it isn't required, so this makes it optional and raises an error/warning when appropriate.

Checklist:

  • This PR has a meaningful title and a clear description.
  • The tests pass.
  • All linting tasks pass.
  • The notebooks are clean.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@jmoralez jmoralez marked this pull request as ready for review August 12, 2024 17:31
@jmoralez jmoralez merged commit 99d2ebf into main Aug 12, 2024
22 checks passed
@jmoralez jmoralez deleted the optional-season-length branch August 12, 2024 17:34
Copy link

codspeed-hq bot commented Aug 12, 2024

CodSpeed Performance Report

Merging #399 will not alter performance

Comparing optional-season-length (6e71438) with main (10c6143)

Summary

✅ 12 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant