fix min_samples_split in random forest space (#380)

Nixtla · Jul 17, 2024 · 1c08dc3 · 1c08dc3
1 parent 91c2a59
commit 1c08dc3
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/mlforecast/auto.py b/mlforecast/auto.py
@@ -102,7 +102,7 @@ def random_forest_space(trial: optuna.Trial):
     return {
         "n_estimators": trial.suggest_int("n_estimators", 50, 1000),
         "max_depth": trial.suggest_int("max_depth", 1, 10),
-        "min_samples_split": trial.suggest_int("min_child_samples", 1, 100),
+        "min_samples_split": trial.suggest_int("min_samples_split", 2, 100),
         "max_features": trial.suggest_float("max_features", 0.5, 1.0),
         "criterion": trial.suggest_categorical(
             "criterion", ["squared_error", "absolute_error"]

diff --git a/nbs/auto.ipynb b/nbs/auto.ipynb
@@ -134,7 +134,7 @@
     "    return {\n",
     "        'n_estimators': trial.suggest_int('n_estimators', 50, 1000),\n",
     "        'max_depth': trial.suggest_int('max_depth', 1, 10),\n",
-    "        'min_samples_split': trial.suggest_int('min_child_samples', 1, 100),\n",
+    "        'min_samples_split': trial.suggest_int('min_samples_split', 2, 100),\n",
     "        'max_features': trial.suggest_float('max_features', 0.5, 1.0),\n",
     "        'criterion': trial.suggest_categorical('criterion', ['squared_error', 'absolute_error']),\n",
     "    }\n",