Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.dbus-next: disable (flaky) tests, remove myself as maintainer #360361

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

SFrijters
Copy link
Member

@SFrijters SFrijters commented Nov 30, 2024

Prior art: #355880

Also related: #357979

Upstream is dead and since I no longer use the package myself I'm not the best person to keep maintaining this.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Upstream is no longer maintained and fixing it the nice way doesn't seem to work,
cf. NixOS#355880
I no longer use this package and upstream seems abandoned.
@SFrijters SFrijters changed the title python3Packages.dbus-next: disble (flaky) tests, remove myself as maintainer python3Packages.dbus-next: disable (flaky) tests, remove myself as maintainer Nov 30, 2024
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/overlay-to-disable-failing-test-in-python-dependency/56857/1

@felixalbrigtsen
Copy link
Member

felixalbrigtsen commented Dec 2, 2024

It seems to fix all the failing dependents, of course:

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 360361


x86_64-linux

✅ 24 packages built:
  • joystickwake
  • joystickwake.dist
  • moonraker
  • pass-secret-service
  • pass-secret-service.dist
  • python311Packages.bless
  • python311Packages.bless.dist
  • python311Packages.dbus-next
  • python311Packages.dbus-next.dist
  • python311Packages.qtile
  • python311Packages.qtile-extras
  • python311Packages.qtile-extras.dist
  • python311Packages.qtile.dist
  • python312Packages.bless
  • python312Packages.bless.dist
  • python312Packages.dbus-next
  • python312Packages.dbus-next.dist
  • python312Packages.qtile
  • python312Packages.qtile-extras
  • python312Packages.qtile-extras.dist
  • python312Packages.qtile.dist
  • sway-assign-cgroups
  • thonny
  • thonny.dist

@K900 K900 merged commit e3ca801 into NixOS:master Dec 3, 2024
39 checks passed
@SFrijters SFrijters deleted the python-dbus-next-disable-tests branch December 3, 2024 12:20
@Aleksanaa Aleksanaa added the backport release-24.11 Backport PR automatically label Dec 3, 2024
@nix-backports
Copy link

nix-backports bot commented Dec 3, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants