Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

moonraker: 0.8.0-unstable-2023-12-27 -> 0.9.3-unstable-2024-11-17 #359404

Merged
merged 1 commit into from
Dec 7, 2024
Merged

moonraker: 0.8.0-unstable-2023-12-27 -> 0.9.3-unstable-2024-11-17 #359404

merged 1 commit into from
Dec 7, 2024

Conversation

nathanregner
Copy link
Contributor

@nathanregner nathanregner commented Nov 26, 2024 •
edited
Loading

Related: #202276, #357979

Fixes broken build until upstream migrates to dbus-fast

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
    • NixOS test(s) (look inside nixos/tests)
    • Manually confirmed system operations (restarting Klipper, Moonraker, rebooting) potentially affected by the switch to dbus-fast work on a real machine. (this is also partially covered by the NixOS tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@matdibu
Copy link
Contributor

matdibu commented Nov 27, 2024

nice, so I guess dbus-fast really is API compatible with dbus-next
thank you!

@nathanregner nathanregner marked this pull request as ready for review November 27, 2024 16:30
@ofborg ofborg bot requested a review from zhaofengli November 27, 2024 17:04
@nathanregner
Copy link
Contributor Author

Removed the dbus-next patch now that dbus-fast has had its tests disabled

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 4, 2024
@wolfgangwalther
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 359404

x86_64-darwin

✅ 1 package built:
  • moonraker

aarch64-darwin

✅ 1 package built:
  • moonraker

@wolfgangwalther wolfgangwalther merged commit 45523aa into NixOS:master Dec 7, 2024
36 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matdibu matdibu matdibu approved these changes

@zhaofengli zhaofengli Awaiting requested review from zhaofengli

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nathanregner @matdibu @wolfgangwalther @wegank