Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nzportable: 2.0.0-indev+20241012190425 -> 2.0.0-indev+20241103095414 & refactorings #357199

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

pluiedev
Copy link
Contributor

@pluiedev pluiedev commented Nov 19, 2024

  • nzportable.fteqw: remove unused plugins
    (Silence some missing plugin errors on first launch)
  • nzportable: passthrough override graphics flags
  • nzportable: separate run script & make it more rigorous
    (Depends on writableDirWrapper: init #361114)
  • nzportable: add desktop item & icons
  • nzportable.quakec: 0-unstable-2024-10-12-12-03-59 -> 0-unstable-2024-11-03-09-54-14

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@pluiedev pluiedev force-pushed the push-mptxqtrsyrvz branch 4 times, most recently from c8d2782 to fa73dc2 Compare November 19, 2024 09:16
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Nov 20, 2024
@pluiedev pluiedev mentioned this pull request Dec 2, 2024
13 tasks
@pluiedev pluiedev marked this pull request as draft December 2, 2024 15:28
@nix-owners nix-owners bot requested a review from philiptaron December 2, 2024 15:28
@pluiedev
Copy link
Contributor Author

pluiedev commented Dec 2, 2024

Making it a draft for now until #361114 is merged

@github-actions github-actions bot added 10.rebuild-darwin: 1-10 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin labels Dec 4, 2024
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant