Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.circus: allow local networking to fix darwin tests #346824

Merged
merged 2 commits into from
Oct 6, 2024

Conversation

GaetanLepage
Copy link
Contributor

@GaetanLepage GaetanLepage commented Oct 6, 2024

Things done

Tests are hanging and failing when trying to rebuild this package on the darwin builder.
Adding __darwinAllowLocalNetworking = true; fixes this problem.

  • python312Packages.circus: add GaetanLepage as maintainer
  • python312Packages.circus: allow local networking to fix darwin tests
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Oct 6, 2024
@GaetanLepage
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 346824


x86_64-linux


aarch64-linux


x86_64-darwin

✅ 6 packages built:
  • circus
  • circus.dist
  • python311Packages.circus
  • python311Packages.circus.dist
  • python312Packages.circus
  • python312Packages.circus.dist

aarch64-darwin

✅ 6 packages built:
  • circus
  • circus.dist
  • python311Packages.circus
  • python311Packages.circus.dist
  • python312Packages.circus
  • python312Packages.circus.dist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants