Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

discord: 0.0.67 -> 0.0.70 #346822

Merged
merged 1 commit into from
Oct 6, 2024
Merged

Conversation

jfvillablanca
Copy link
Member

@jfvillablanca jfvillablanca commented Oct 6, 2024

Closes #346756

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@jfvillablanca
Copy link
Member Author

Result of nixpkgs-review pr 346822 run on x86_64-linux 1

1 package built:
  • discord

@Scrumplex
Copy link
Member

Result of nixpkgs-review pr 346822 run on x86_64-linux 1

1 package built:
  • discord

@jopejoe1 jopejoe1 added the backport release-24.05 Backport PR automatically label Oct 6, 2024
@jopejoe1 jopejoe1 merged commit f74a665 into NixOS:master Oct 6, 2024
35 of 36 checks passed
Copy link
Contributor

github-actions bot commented Oct 6, 2024

Backport failed for release-24.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-24.05
git worktree add -d .worktree/backport-346822-to-release-24.05 origin/release-24.05
cd .worktree/backport-346822-to-release-24.05
git switch --create backport-346822-to-release-24.05
git cherry-pick -x 1c9844ef89eeca2da48c805545ddbab09c9ce5e2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update request: discord 0.0.67 → 0.0.70
3 participants