-
-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xen: nuke, move to by-name. #345192
base: master
Are you sure you want to change the base?
xen: nuke, move to by-name. #345192
Conversation
Do package sets work with by-name? |
I don't think so. This also sends all |
I have reached the conclusion I have no idea what I'm doing. |
787325c
to
6d5681b
Compare
Hate to say it, but this is a violation of the It’s also fine to just not be in |
Ah, yes:
|
The problem is that With the |
But you only satisfy that condition because you violate this one:
|
6d5681b
to
dcca5b9
Compare
dcca5b9
to
3bb65e6
Compare
d483a5f
to
7097e9f
Compare
709f2d6
to
daf2778
Compare
daf2778
to
18e34f0
Compare
5c2bbbc
to
f21e1b1
Compare
- Removes the non-slim build instructions, massively simplifying everything in the package. - Removes unecessary patches. - Inherits functions from lib instead of repeating lib.* everywhere. Signed-off-by: Fernando Rodrigues <[email protected]>
It was incredibly slow and will be replaced by something r-ryantm can run soon. Signed-off-by: Fernando Rodrigues <[email protected]>
Signed-off-by: Fernando Rodrigues <[email protected]> Co-authored-by: Yaroslav Bolyukin <[email protected]> Co-authored-by: Emily <[email protected]>
…ths. Signed-off-by: Fernando Rodrigues <[email protected]>
…nd the xenPackages set Signed-off-by: Fernando Rodrigues <[email protected]>
Signed-off-by: Fernando Rodrigues <[email protected]>
Signed-off-by: Fernando Rodrigues <[email protected]>
QEMU could already build a pretty okay qemu_xen, but it's best to use Xen's own sources and explicitly enable Xen support. Signed-off-by: Fernando Rodrigues <[email protected]>
Signed-off-by: Fernando Rodrigues <[email protected]>
Signed-off-by: Fernando Rodrigues <[email protected]>
They were removed during the great Xen deletion. Signed-off-by: Fernando Rodrigues <[email protected]>
f21e1b1
to
12f2ce0
Compare
Description of changes
Things done
nix-shell -p nixpkgs-review --run "nixpkgs-review pr 345192"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.