-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkgs/README.md: classify and add rules to the naming convention #340452
pkgs/README.md: classify and add rules to the naming convention #340452
Conversation
3868537
to
165cf93
Compare
165cf93
to
41b0768
Compare
41b0768
to
16d35db
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm in favor of the semantic change. Thanks for taking the time @Aleksanaa!
Left a bunch of purely formal suggestions.
164d67d
to
0a34185
Compare
@fricklerhandwerk Would you give a final review? It looks good from my side now. I'd also like to refactor more of this README to make the structure clear, but I don't want to expand the scope of this PR too much |
Co-authored-by: Valentin Gagarin <[email protected]>
Co-authored-by: Valentin Gagarin <[email protected]>
0a34185
to
145fde5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you have more clarifications for this document, I'm glad to review those, too. This is a dense text and it doesn't exactly make contributions easier if you want to follow all the rules.
This is what I had in mind. IMO it's logically better, but conventions goes to bottom and I'm afraid less people would carefully read it (there's side pane on GitHub tho). I didn't modify most of texts here, just rearranging it, so the wording problem should be omitted. Only this is newly added:
I have to go to sleep now. It would be helpful if you can express a brief opinion on this. Thanks! |
Oh, slight misunderstanding... let's do further changes in a follow up PR. I was ready to merge this. |
606c7f4
to
145fde5
Compare
@fricklerhandwerk dropped |
Description of changes
This is noticed in NixOS/nixpkgs-vet#107, and we should explicitly tell contributors how to deal with variables starting with a digit.
Rendered
Add a 👍 reaction to pull requests you find important.