-
-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vimPlugins.leetcode-nvim: init at 2024-06-27 #340378
base: master
Are you sure you want to change the base?
Conversation
Close #274061 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
c3a3236
to
cb98609
Compare
Also updated the SHA as it was incorrect; apologies. I double checked it with |
cb98609
to
2f35f26
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have made minor cosmetic changes.
Result of 1 package failed to build:
1 package built:
|
Looks like dependencies are not transitive: cc @teto (I have been pinging you a lot lately, sorry for that) |
2f35f26
to
dc2ec23
Compare
Result of 1 package failed to build:
1 package built:
|
1 similar comment
Result of 1 package failed to build:
1 package built:
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to fix the require
check.
ha indeed. The neovimRequireCheckHook just adds the listed dependencies to RTP. a quickfix could be to add |
#342240 fixes it, no? |
I dont think so, it will just expand the derivation |
No, because b858149 is #342240, which is currently in staging-next and not in master (https://nixpk.gs/pr-tracker.html?pr=342240) EDIT: see also #343421 |
Oh right, I got tricked by the "merged" status. |
Description of changes
Adds the plugin leetcode.nvim.
Includes hard dependencies
telescope-nvim
andnui-nvim
.Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.