Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python312Packages.pyopencl: 2024.2.6 -> 2024.2.7 #337876

Merged
merged 7 commits into from
Aug 28, 2024
Merged

python312Packages.pyopencl: 2024.2.6 -> 2024.2.7 #337876

merged 7 commits into from
Aug 28, 2024

Conversation

GaetanLepage
Copy link
Contributor

@GaetanLepage GaetanLepage commented Aug 28, 2024 •
edited
Loading

Description of changes

  • python312Packages.pyopencl: 2024.2.6 -> 2024.2.7
  • python312Packages.pyopencl: add GaetanLepage as maintainer

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@GaetanLepage
Copy link
Contributor Author

I will need a bit of help on this one as I get weird ModuleNotFound errors:

Check whether the following modules can be imported: pyopencl pyopencl.array pyopencl.compyte
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "<string>", line 1, in <lambda>
  File "/nix/store/04gg5w1s662l329a8kh9xcwyp0k64v5a-python3-3.12.4/lib/python3.12/importlib/__init__.py", line 90, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<frozen importlib._bootstrap>", line 1387, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1360, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1331, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 935, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 995, in exec_module
  File "<frozen importlib._bootstrap>", line 488, in _call_with_frames_removed
  File "/nix/store/ymsdh7v94cpj4p0ncakir43lkx9hs051-python3.12-pyopencl-2024.2.7/lib/python3.12/site-packages/pyopencl/__init__.py", line 29, in <module>
    import pyopencl.cltypes  # noqa: F401
    ^^^^^^^^^^^^^^^^^^^^^^^
  File "/nix/store/ymsdh7v94cpj4p0ncakir43lkx9hs051-python3.12-pyopencl-2024.2.7/lib/python3.12/site-packages/pyopencl/cltypes.py", line 25, in <module>
    from pyopencl.tools import get_or_register_dtype
  File "/nix/store/ymsdh7v94cpj4p0ncakir43lkx9hs051-python3.12-pyopencl-2024.2.7/lib/python3.12/site-packages/pyopencl/tools.py", line 139, in <module>
    from pyopencl.compyte.dtypes import TypeNameNotKnown  # noqa: F401
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ModuleNotFoundError: No module named 'pyopencl.compyte'

@GaetanLepage
Copy link
Contributor Author

Ok, I will leave the test weirdness out for now.
I have only left the update and the cleaning bits.
Also, everything has been split in smaller commits.
The package builds fine now.

@GaetanLepage
Copy link
Contributor Author

Result of nixpkgs-review pr 337876 run on aarch64-darwin 1

16 packages marked as broken and skipped:
  • python311Packages.loopy
  • python311Packages.loopy.dist
  • python311Packages.pyopencl
  • python311Packages.pyopencl.dist
  • python311Packages.reikna
  • python311Packages.reikna.dist
  • python311Packages.sasmodels
  • python311Packages.sasmodels.dist
  • python312Packages.loopy
  • python312Packages.loopy.dist
  • python312Packages.pyopencl
  • python312Packages.pyopencl.dist
  • python312Packages.reikna
  • python312Packages.reikna.dist
  • python312Packages.sasmodels
  • python312Packages.sasmodels.dist

@GaetanLepage
Copy link
Contributor Author

Result of nixpkgs-review pr 337876 run on x86_64-darwin 1

@GaetanLepage
Copy link
Contributor Author

Result of nixpkgs-review pr 337876 run on aarch64-linux 1

16 packages built:
  • python311Packages.loopy
  • python311Packages.loopy.dist
  • python311Packages.pyopencl
  • python311Packages.pyopencl.dist
  • python311Packages.reikna
  • python311Packages.reikna.dist
  • python311Packages.sasmodels
  • python311Packages.sasmodels.dist
  • python312Packages.loopy
  • python312Packages.loopy.dist
  • python312Packages.pyopencl
  • python312Packages.pyopencl.dist
  • python312Packages.reikna
  • python312Packages.reikna.dist
  • python312Packages.sasmodels
  • python312Packages.sasmodels.dist

@GaetanLepage
Copy link
Contributor Author

Result of nixpkgs-review pr 337876 run on x86_64-linux 1

16 packages built:
  • python311Packages.loopy
  • python311Packages.loopy.dist
  • python311Packages.pyopencl
  • python311Packages.pyopencl.dist
  • python311Packages.reikna
  • python311Packages.reikna.dist
  • python311Packages.sasmodels
  • python311Packages.sasmodels.dist
  • python312Packages.loopy
  • python312Packages.loopy.dist
  • python312Packages.pyopencl
  • python312Packages.pyopencl.dist
  • python312Packages.reikna
  • python312Packages.reikna.dist
  • python312Packages.sasmodels
  • python312Packages.sasmodels.dist

@GaetanLepage GaetanLepage marked this pull request as ready for review August 28, 2024 11:50
SuperSandro2000
SuperSandro2000 approved these changes Aug 28, 2024
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't need to do micro commits while also not doing everything in one. I think the middle ground in between is the right choice but we leave it like it is now.

@GaetanLepage GaetanLepage merged commit 036aeed into NixOS:master Aug 28, 2024
42 of 44 checks passed
@GaetanLepage GaetanLepage deleted the pyopencl branch August 28, 2024 12:27
@GaetanLepage GaetanLepage mentioned this pull request Aug 28, 2024
Merged
13 tasks
@dotlambda
Copy link
Member

dotlambda commented Aug 28, 2024 •
edited
Loading

Excuse me?? #336885
I reverted this PR. Please implement your changes again on top of mine.

@dotlambda dotlambda mentioned this pull request Aug 28, 2024
Merged
@GaetanLepage
Copy link
Contributor Author

Excuse me?? #336885
I reverted this PR. Please implement your changes again on top of mine.

Sorry, I have missed yours. Will do !

@doronbehar
Copy link
Contributor

Excuse me?? #336885
I reverted this PR. Please implement your changes again on top of mine.

Sorry, I have missed yours. Will do !

What happened here exactly?

@GaetanLepage
Copy link
Contributor Author

What happened here exactly?

dotlambda already had a PR ready for this update and mine got merged before his.
Hence, he preferred to revert this one and merge the original PR.

@doronbehar
Copy link
Contributor

What happened here exactly?

dotlambda already had a PR ready for this update and mine got merged before his. Hence, he preferred to revert this one and merge the original PR.

That's what happens when there is no active maintainer for a package to coordinate such changes.

@dotlambda
Copy link
Member

What happened here exactly?

dotlambda already had a PR ready for this update and mine got merged before his. Hence, he preferred to revert this one and merge the original PR.

That's what happens when there is no active maintainer for a package to coordinate such changes.

That's why I always search existing PRs before suggesting a change. So should everyone else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@doronbehar doronbehar Awaiting requested review from doronbehar

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GaetanLepage @dotlambda @doronbehar @SuperSandro2000