python312Packages.matplotlib: 3.8.4 -> 3.9.0 #316041
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: https://github.com/matplotlib/matplotlib/releases/tag/v3.9.0
Description of changes
Currently still a draft, due to this upstream issue (that apparently only we experience?). Also intentionally I target
master
and notstaging
, so that I'll be able to use the CI more easily once this gets ready.I'm still opening this, to let the maintainers know that I'm "on it", and to share the slightly non-trivial work needed to get this working.
As for the last commit that enables the tests, I'm fairly sure that at least we won't get circular import errors as described in #255262 , but perhaps many tests fail due to our freetype library different then upstream (and upstream compares the images bit by bit). So I'll see how CI runs the tests for all platforms and decide than (once upstream issue will be resolved).
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.