Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python311Packages.pykwalify: fix tests with ruamel.yaml 0.18+ #282468

Merged
merged 1 commit into from
Jan 21, 2024

Conversation

lilyinstarlight
Copy link
Member

@lilyinstarlight lilyinstarlight commented Jan 21, 2024

Description of changes

Pull in upstream fix from Grokzen/pykwalify#199

Currently failing in Hydra otherwise: https://hydra.nixos.org/build/246491825

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.
nixpkgs-review

Result of nixpkgs-review run on x86_64-linux 1

6 packages marked as broken and skipped:
  • python312Packages.pykwalify
  • python312Packages.pykwalify.dist
  • python312Packages.pyradiomics
  • python312Packages.pyradiomics.dist
  • python312Packages.west
  • python312Packages.west.dist
6 packages built:
  • python311Packages.pykwalify
  • python311Packages.pykwalify.dist
  • python311Packages.pyradiomics
  • python311Packages.pyradiomics.dist
  • python311Packages.west
  • python311Packages.west.dist

Add a 👍 reaction to pull requests you find important.

@NickCao NickCao merged commit ba82cca into NixOS:master Jan 21, 2024
27 checks passed
@lilyinstarlight lilyinstarlight deleted the fix/pykwalify-tests branch January 21, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants