Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wordpressPackages: Add German plugin translations #247579

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

onny
Copy link
Contributor

@onny onny commented Aug 6, 2023

Description of changes

Adding translation German translation files to plugin packages.

Tested it with:

{ pkgs, ... }:{

  services.wordpress.sites."localhost" = {
    themes = {
      inherit (pkgs.wordpressPackages.themes)
        twentytwentythree;
    };
    plugins = {
      inherit (pkgs.wordpressPackages.plugins)
        jetpack;
    };
    languages = [ pkgs.wordpressPackages.languages.de_DE ];
    settings = {
      WPLANG = "de_DE";
      JETPACK_DEV_DEBUG = true;
    };
  };

}

Fixes helsinki-systems/wp4nix#2

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@onny
Copy link
Contributor Author

onny commented Aug 6, 2023

@mohe2015 I saw that translation files for Wordpress plugins were missing. I did some research on how it works and trying to implement packaging here helsinki-systems/wp4nix#2

I would like to have an additional plugin package output "i18l" where the plugin translation files are located

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild labels Aug 6, 2023
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Aug 7, 2023
@ofborg ofborg bot added 10.rebuild-linux: 1-10 and removed 10.rebuild-linux: 0 This PR does not cause any packages to rebuild labels Aug 7, 2023
@wegank wegank added 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 2.status: merge conflict This PR has merge conflicts with the target branch labels Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

translation files for themes and plugins missing
2 participants