Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mailcatcher: 0.7.1 -> 1.0.0.beta1 #203942

Closed
wants to merge 1 commit into from

Conversation

thenonameguy
Copy link
Contributor

Fixes #96908

Switching to fork that uses async library, this fixes darwin builds. sj26/mailcatcher#467

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

Fixes NixOS#96908

Switching to fork that uses async library, this fixes darwin builds.
sj26/mailcatcher#467
@zarelit
Copy link
Member

zarelit commented Dec 1, 2022

@thenonameguy problem is that the PR used is not even mergeable upstream at the moment because it has conflicts left from a year ago

@thenonameguy
Copy link
Contributor Author

I am aware, but for my development purposes this solves the problem.
I would be happy to have a separate derivation in nixpkgs as a secondary solution. mailcatcher-async maybe?

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 18, 2023
@zarelit
Copy link
Member

zarelit commented Aug 1, 2023

@thenonameguy I think this can be closed. Mailcatcher is working again on darwin (both x86_64 and aarch64) and the async version adds nothing to the user except not being dependent from eventmachine.

The async version will eventually land in mailcatcher upstream (according to author: sj26/mailcatcher#546 (comment) ) but in the meantime you can publish this derivation in NUR or as a flake.

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mailcatcher Ruby gem with native extension broken on macOS
2 participants