Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swaylock-effects: changed source repository #180816

Merged
merged 1 commit into from
Dec 27, 2022

Conversation

aacebedo
Copy link
Contributor

@aacebedo aacebedo commented Jul 9, 2022

Description of changes

Original repository seems not maintained anymore.
The new repo maintained by jirutka is up to date and seems to be a better option to base to package upon.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

Original repository seems not maintained anymore.
The new repo maintained by jirutka is up to date.
@applePrincess
Copy link
Contributor

mortie/swaylock-effects#92 discusses the current state of upstream repo.

@oxalica
Copy link
Contributor

oxalica commented Oct 21, 2022

Could we deprecate the current package and add a new one, so that downstream users are aware of this upstream switch?

Note that the current sway-effects in nixpkgs has security holes by not implementing ext-session-lock protocol swaywm/swaylock#204 . Though this requires master sway to work.

@Ma27
Copy link
Member

Ma27 commented Oct 21, 2022

OK that's it... I need to dodge swaylock (or whatever fork). It violated my trust too often now.

@Ma27 Ma27 removed their request for review October 21, 2022 09:01
@Ma27
Copy link
Member

Ma27 commented Oct 21, 2022

Also, donwe use sway master? If not we should consider marking swaylock as insecure tbh.

@aacebedo
Copy link
Contributor Author

not even sure i shall maintain the change here. The author of the new repository is not responding anymore so it may end up as another dead package. @Ma27 do ou have any alternative to sway lock ?

@Artturin
Copy link
Member

other repos have switched to this fork too https://repology.org/project/swaylock-effects/versions

@Artturin Artturin merged commit f73cdf0 into NixOS:master Dec 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants