Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

powerdevil: drop ddcutil dependency #172078

Merged
merged 1 commit into from
May 9, 2022
Merged

powerdevil: drop ddcutil dependency #172078

merged 1 commit into from
May 9, 2022

Conversation

K900
Copy link
Contributor

@K900 K900 commented May 8, 2022

Description of changes

This is kind of a weird one, because ddcutil is not obviously broken from an end user perspective, but it is very broken conceptually, and it can lead to lots of interesting side effects. Basically, what ddcutil does is it tries to talk DDC to a display over an I2C bus. The problems with that are:

  1. DDC is a legacy protocol that modern displays implement in increasingly broken ways.
  2. Poking random I2C buses from userspace requires special permissions and can lead to explosions.
  3. The ddcutil integration in Powerdevil is very, very broken, effectively unmaintained and even upstream recommends not using it.
  4. Most modern GPU drivers expose native brightness controls in sysfs, which PowerDevil natively supports.

Might be release note worthy, but I decided to throw it out there first and see how people feel about it.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@K900 K900 requested a review from ttuegel as a code owner May 8, 2022 18:40
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels May 8, 2022
@SuperSandro2000 SuperSandro2000 merged commit 644ae48 into NixOS:master May 9, 2022
K900 added a commit to K900/nixpkgs that referenced this pull request Mar 17, 2023
The code for this was actually removed in NixOS#172078.
@sund3RRR sund3RRR mentioned this pull request Feb 2, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: qt/kde 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants