Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws-sdk-cpp: 1.8.130 -> 1.9.119, init new dependency packages #141014

Merged
merged 10 commits into from
Oct 16, 2021
Merged

aws-sdk-cpp: 1.8.130 -> 1.9.119, init new dependency packages #141014

merged 10 commits into from
Oct 16, 2021

Conversation

r-burns
Copy link
Contributor

@r-burns r-burns commented Oct 8, 2021 •
edited
Loading

Motivation for this change

The aws-sdk-cpp 1.9 release significantly refactored the project structure, bringing in aws-crt-cpp which itself consumes many new aws-c-* packages via submodules. We're not the only distro that's getting tripped up by this - take a look at the spread in https://repology.org/project/aws-sdk-cpp/versions, and some of the conversation involving other repo packagers in aws/aws-sdk-cpp#1648.

This PR:

  • adds any missing aws-c-* libs
  • builds aws-crt-cpp using these libs as full-fledged packages rather than vendored submodules
  • builds aws-sdk-cpp 1.9.x using the new aws-crt-cpp dependency
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@r-burns
s2n-tls: cleanup
359481f 
* fix LibCrypto cmake paths
* fix postInstall for static build
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Oct 8, 2021
@ofborg ofborg bot requested a review from edolstra October 8, 2021 20:24
@r-burns
Copy link
Contributor Author

r-burns commented Oct 8, 2021

I've built nix and nixUnstable on x86_64-linux. I'm trying to do the same on darwin but the hydra jobs are lagging far behind so it might take a while.

@r-burns
Copy link
Contributor Author

r-burns commented Oct 9, 2021

Okay, working on x86_64-darwin as well.

@r-burns r-burns requested a review from orivej-nixos October 11, 2021 18:15
@r-burns r-burns force-pushed the aws-bump-to-end-all-bumps branch from 4bf0f01 to 21bef4a Compare October 12, 2021 05:40
@r-burns r-burns changed the title aws-sdk-cpp: 1.8.130 -> 1.9.117, init new dependency packages aws-sdk-cpp: 1.8.130 -> 1.9.119, init new dependency packages Oct 12, 2021
@r-burns
Copy link
Contributor Author

r-burns commented Oct 12, 2021

Result of nixpkgs-review pr 141014 run on x86_64-linux 1

1 package failed to build:
  • nixos-install-tools
73 packages built:
  • aws-c-auth
  • aws-c-cal
  • aws-c-common
  • aws-c-compression
  • aws-c-event-stream
  • aws-c-http
  • aws-c-io
  • aws-c-mqtt
  • aws-c-s3
  • aws-checksums
  • aws-crt-cpp
  • aws-sdk-cpp
  • bundix
  • cabal2nix
  • cachix
  • common-updater-scripts
  • crate2nix
  • crystal2nix
  • dep2nix
  • dydisnix
  • fusionInventory
  • go2nix
  • hci
  • hercules-ci-agent
  • hubstaff
  • hydra-unstable
  • libnixxml
  • lispPackages.quicklisp-to-nix
  • lispPackages.quicklisp-to-nix-system-info
  • nix (nixStable)
  • nix-binary-cache
  • nix-bundle
  • nix-direnv
  • nix-direnv-flakes
  • nix-doc
  • nix-du
  • nix-eval-jobs
  • nix-index
  • nix-pin
  • nix-plugins
  • nix-prefetch
  • nix-prefetch-bzr
  • nix-prefetch-cvs
  • nix-prefetch-docker
  • nix-prefetch-git
  • nix-prefetch-hg
  • nix-prefetch-scripts
  • nix-prefetch-svn
  • nix-review (nixpkgs-review)
  • nix-serve
  • nix-simple-deploy
  • nix-template
  • nix-update
  • nix-update-source
  • nixFlakes (nixUnstable)
  • nix_2_4
  • nixos-generators
  • nixos-option
  • nixos-rebuild
  • nixos-shell
  • nixui
  • nvfetcher
  • python38Packages.nix-kernel
  • python38Packages.nixpkgs
  • python38Packages.pythonix
  • python39Packages.nix-kernel
  • python39Packages.nixpkgs
  • python39Packages.pythonix
  • rnix-lsp
  • s2n (s2n-tls)
  • update-nix-fetchgit
  • vgo2nix
  • vulnix

@r-burns r-burns force-pushed the aws-bump-to-end-all-bumps branch from 21bef4a to c5e5faf Compare October 12, 2021 19:53
@r-burns r-burns force-pushed the aws-bump-to-end-all-bumps branch from c5e5faf to abbb7c6 Compare October 15, 2021 03:25
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).

Result of nixpkgs-review pr 141014 run on x86_64-linux 1

1 package marked as broken and skipped:
  • ovftool
3 packages blacklisted:
  • tests.nixos-functions.nixos-test
  • tests.nixos-functions.nixosTest-test
  • tests.trivial
1 package failed to build and are new build failure:
  • nixos-install-tools: log was empty
81 packages built:
  • aws-c-auth
  • aws-c-cal
  • aws-c-common
  • aws-c-compression
  • aws-c-event-stream
  • aws-c-http
  • aws-c-io
  • aws-c-mqtt
  • aws-c-s3
  • aws-checksums
  • aws-crt-cpp
  • aws-sdk-cpp
  • bundix
  • cabal2nix
  • cachix
  • common-updater-scripts
  • crate2nix
  • crystal2nix
  • dep2nix
  • dydisnix
  • fusionInventory
  • go2nix
  • haskellPackages.cabal2nix-unstable
  • haskellPackages.cachix
  • haskellPackages.hercules-ci-agent
  • haskellPackages.hercules-ci-cli
  • haskellPackages.hercules-ci-cnix-expr
  • haskellPackages.hercules-ci-cnix-store
  • haskellPackages.nix-paths
  • haskellPackages.nvfetcher
  • haskellPackages.update-nix-fetchgit
  • hci
  • hercules-ci-agent
  • hubstaff
  • hydra-unstable
  • libnixxml
  • lispPackages.quicklisp-to-nix
  • lispPackages.quicklisp-to-nix-system-info
  • nix (nixStable)
  • nix-bundle
  • nix-direnv
  • nix-direnv-flakes
  • nix-doc
  • nix-du
  • nix-eval-jobs
  • nix-index
  • nix-pin
  • nix-plugins
  • nix-prefetch
  • nix-prefetch-bzr
  • nix-prefetch-cvs
  • nix-prefetch-docker
  • nix-prefetch-git
  • nix-prefetch-hg
  • nix-prefetch-scripts
  • nix-prefetch-svn
  • nix-serve
  • nix-simple-deploy
  • nix-template
  • nix-update
  • nix-update-source
  • nixUnstable
  • nix_2_4
  • nixos-generators
  • nixos-option
  • nixos-rebuild
  • nixos-shell
  • nixpkgs-review
  • nixui
  • nvfetcher
  • python38Packages.nix-kernel
  • python38Packages.nixpkgs
  • python38Packages.pythonix
  • python39Packages.nix-kernel
  • python39Packages.nixpkgs
  • python39Packages.pythonix
  • rnix-lsp
  • s2n-tls
  • update-nix-fetchgit
  • vgo2nix
  • vulnix

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

lispPackages.quicklisp-to-nix:

An avoidable string conversion got detected: rev = "${version}";
Please do not convert variables to a string without modifying them but use them directly instead.

lispPackages.quicklisp-to-nix-system-info:

An avoidable string conversion got detected: rev = "${version}";
Please do not convert variables to a string without modifying them but use them directly instead.

@SuperSandro2000 SuperSandro2000 merged commit 9ff962d into NixOS:master Oct 16, 2021
@r-burns r-burns deleted the aws-bump-to-end-all-bumps branch October 16, 2021 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edolstra edolstra Awaiting requested review from edolstra

@orivej-nixos orivej-nixos Awaiting requested review from orivej-nixos

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@r-burns @SuperSandro2000