Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws-c-common: disable flaky test #134680

Merged
merged 1 commit into from
Aug 18, 2021
Merged

aws-c-common: disable flaky test #134680

merged 1 commit into from
Aug 18, 2021

Conversation

happysalada
Copy link
Contributor

Motivation for this change

this aws-c-common test is known to be flaky.
I've opened an issue upstream, without answer. awslabs/aws-c-common#834
I propose to disable it for now.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@happysalada happysalada requested a review from r-burns August 18, 2021 17:14
@ofborg ofborg bot requested a review from edolstra August 18, 2021 17:31
SuperSandro2000
SuperSandro2000 reviewed Aug 18, 2021
View reviewed changes
pkgs/development/libraries/aws-c-common/default.nix
Comment on lines +28 to +30
cat <<EOW >CTestCustom.cmake
SET(CTEST_CUSTOM_TESTS_IGNORE promise_test_multiple_waiters)
EOW
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
cat <<EOW >CTestCustom.cmake
SET(CTEST_CUSTOM_TESTS_IGNORE promise_test_multiple_waiters)
EOW
cat <<EOF >CTestCustom.cmake
SET(CTEST_CUSTOM_TESTS_IGNORE promise_test_multiple_waiters)
EOF

@SuperSandro2000 SuperSandro2000 merged commit 1ebe775 into NixOS:master Aug 18, 2021
@happysalada
Copy link
Contributor Author

Thank you!

@happysalada happysalada deleted the aws_c_common_disable_flaky_test branch August 19, 2021 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@r-burns r-burns Awaiting requested review from r-burns

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@happysalada @SuperSandro2000