Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flakes: split sources #805

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

flakes: split sources #805

wants to merge 1 commit into from

Conversation

wegank
Copy link
Member

@wegank wegank commented Jun 26, 2024 •
edited
Loading

This PR splits flakes/manual.toml into multiple files under flakes/manual/, and modifies .github/workflows/check-flake-files.yml so that it only runs on the modified files.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 26, 2024 •
edited
Loading

🚀 Deployed on https://67431283f357efa3f7843fdc--nixos-search.netlify.app

@github-actions github-actions bot temporarily deployed to pull request June 26, 2024 12:26 Inactive
@wegank wegank force-pushed the flakes-split-sources branch from 68d57f8 to 4ec60c1 Compare June 26, 2024 12:37
@github-actions github-actions bot temporarily deployed to pull request June 26, 2024 12:38 Inactive
@wegank wegank marked this pull request as ready for review June 26, 2024 12:47
@wegank wegank force-pushed the flakes-split-sources branch from 4ec60c1 to 834500d Compare June 26, 2024 15:04
@github-actions github-actions bot temporarily deployed to pull request June 26, 2024 15:05 Inactive
@wegank wegank force-pushed the flakes-split-sources branch from 834500d to aeae7bf Compare June 27, 2024 08:27
@github-actions github-actions bot temporarily deployed to pull request June 27, 2024 08:28 Inactive
@wegank wegank force-pushed the flakes-split-sources branch from aeae7bf to 84a7ae2 Compare June 27, 2024 09:10
@github-actions github-actions bot temporarily deployed to pull request June 27, 2024 09:11 Inactive
@wegank wegank force-pushed the flakes-split-sources branch from 84a7ae2 to de58530 Compare June 27, 2024 11:14
@github-actions github-actions bot temporarily deployed to pull request June 27, 2024 11:15 Inactive
@wegank wegank force-pushed the flakes-split-sources branch from de58530 to 818ed9a Compare June 27, 2024 15:50
@github-actions github-actions bot temporarily deployed to pull request June 27, 2024 15:51 Inactive
@wegank wegank force-pushed the flakes-split-sources branch from 818ed9a to f97d437 Compare June 27, 2024 20:43
@github-actions github-actions bot temporarily deployed to pull request June 27, 2024 20:44 Inactive
@wegank wegank force-pushed the flakes-split-sources branch from f97d437 to f970611 Compare June 28, 2024 08:39
@github-actions github-actions bot temporarily deployed to pull request June 28, 2024 08:40 Inactive
@wegank wegank force-pushed the flakes-split-sources branch from f970611 to 76ab1a2 Compare August 8, 2024 13:22
@github-actions github-actions bot temporarily deployed to pull request August 8, 2024 13:23 Inactive
@wegank wegank force-pushed the flakes-split-sources branch from 76ab1a2 to 7d6ea20 Compare September 29, 2024 14:06
@github-actions github-actions bot temporarily deployed to pull request September 29, 2024 14:07 Inactive
dasJ
dasJ reviewed Oct 14, 2024
View reviewed changes
Copy link
Member

@dasJ dasJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, sorry this took me so long to take a look at.

I really like the direction this is going. This does however only address the PR checks and not the actual import. That would be where the actual issues surface when a downstream flake breaks. So I think we should loop over the groups in the import as well, write them to a yaml (maybe? it should at least be concat'able) and bulk-import that into ES.

@wegank
Copy link
Member Author

wegank commented Oct 15, 2024

Hey, sorry this took me so long to take a look at.

I really like the direction this is going. This does however only address the PR checks and not the actual import. That would be where the actual issues surface when a downstream flake breaks. So I think we should loop over the groups in the import as well, write them to a yaml (maybe? it should at least be concat'able) and bulk-import that into ES.

I've also lost track of the PR, but I think the one-line change in .github/workflows/import-to-elasticsearch.yml does exactly that?

@wegank wegank force-pushed the flakes-split-sources branch from 7d6ea20 to 51e81a7 Compare November 24, 2024 11:47
@github-actions github-actions bot temporarily deployed to pull request November 24, 2024 11:48 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dasJ dasJ dasJ left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wegank @dasJ