Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable acpi.ec_no_wakeup in Thinkpad T14 AMD Gen 5 #1267

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kowale
Copy link

@kowale kowale commented Dec 2, 2024

Description of changes

This PR should remove constant battery drain specific to this device (and others, but I only have this one to test) as suggested in e.g.

Things done
  • Tested the changes in your own NixOS Configuration (kowale/homelab@a46e5de#diff-37d03cb9538bb32044b321a8a2cad7aafe9ec114d6b9f83e1d40e917edcc14f4R46 is working on my machine. Before this commit, I had to keep my laptop charging at all times, as it would drain in a few hours, even on suspend, unless fully shutdown. After this commit, I can leave my laptop with its lid closed for 10 hours at the expense of about 4% of battery!)
  • Tested the changes end-to-end by using your fork of nixos-hardware (I was already using this nixos-hardware input in my config, so counting this as done, as it should be identical, right?)

@kowale
Copy link
Author

kowale commented Dec 2, 2024

I see the tests are failing for

  • x86_64-linux.nixos-stable-focus-m2-gen1
  • x86_64-linux.nixos-unstable-focus-m2-gen1

but these don't seem related. Flaky tests?

@Mic92
Copy link
Member

Mic92 commented Dec 3, 2024

@mergify rebase

Copy link
Contributor

mergify bot commented Dec 3, 2024

rebase

✅ Branch has been successfully rebased

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants