Make Machine::systemTypes a set not vector
#9838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is more conceptually correct (the order does not matter), and also matches what Hydra already does. (Nix and Hydra matching is needed for dedup NixOS/hydra#1164)
There's just enough logic (the `"builtin"` special case) that makes this worthy of its own method.
fricklerhandwerk
approved these changes
Jan 23, 2024
roberth
approved these changes
Jan 23, 2024
tebowy
pushed a commit
to tebowy/nix
that referenced
this pull request
Jul 11, 2024
Make `Machine::systemTypes` a set not vector (cherry picked from commit f1b0304) Change-Id: I6d4f5c0bfc226e9bd66c58c360cd99e3fac9a129
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is more conceptually correct (the order does not matter), and also matches what Hydra already does.
Context
Nix and Hydra matching is needed for dedup
NixOS/hydra#1164
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.