Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.3] Add flake for testing purposes #9771

Merged
merged 2 commits into from
Jan 26, 2024

Conversation

roberth
Copy link
Member

@roberth roberth commented Jan 15, 2024

Motivation

Makes it easier to answer questions about this old release.

E.g.

nix run nix/2.3-maintenance#nix-daemon -- --help

or to try this PR's branch:

nix run github:hercules-ci/nix/2.3-flake#nix-daemon -- --help

We may consider forward porting the apps.

Context

Priorities and Process

Add 👍 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

The purpose for this flake is to make `nix run nix/2.3-maintenance` work,
so that it's easier to answer questions about this old series of releases.
@roberth roberth added the contributor-experience Developer experience for Nix contributors label Jan 15, 2024
Copy link
Member

@thufschmitt thufschmitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! 💯

Do you know what's causing the MacOS failure?

@roberth
Copy link
Member Author

roberth commented Jan 15, 2024

MacOS failure?

I probably messed up the backport of 02dd6bb

@thufschmitt thufschmitt merged commit ec26251 into NixOS:2.3-maintenance Jan 26, 2024
4 of 6 checks passed
@thufschmitt
Copy link
Member

Discussed during the maintainers meeting on 2024-01-19:

Approved. The CI failure is unrelated, can merge any way, but need to open an issue for it.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/2024-01-19-nix-team-meeting-minutes-116/38837/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor-experience Developer experience for Nix contributors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants